FIX l10n_it_fiscalcode check when e-commerce user sets 'company_name'

TheMule71 · Nov 11, 2022 · 89cc2c5 · 89cc2c5
1 parent ca82ce8
commit 89cc2c5
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 9 deletions.
diff --git a/l10n_it_fiscalcode/__manifest__.py b/l10n_it_fiscalcode/__manifest__.py
@@ -6,7 +6,7 @@
 
 {
     'name': 'Italian Localization - Fiscal Code',
-    'version': '12.0.1.1.0',
+    'version': '12.0.1.1.1',
     'development_status': 'Production/Stable',
     'category': 'Localisation/Italy',
     'author': "Link IT s.r.l., "

diff --git a/l10n_it_fiscalcode/model/res_partner.py b/l10n_it_fiscalcode/model/res_partner.py
@@ -10,14 +10,19 @@ class ResPartner(models.Model):
     def check_fiscalcode(self):
         for partner in self:
             if not partner.fiscalcode:
-                return True
-            elif (
-                len(partner.fiscalcode) != 16 and
-                partner.company_type == 'person'
-            ):
-                return False
-            else:
-                return True
+                # Because it is not mandatory
+                continue
+            elif partner.company_type == 'person':
+                # Person case
+                if partner.company_name:
+                    # In E-commerce, if there is company_name,
+                    # the user might insert VAT in fiscalcode field.
+                    # Perform the same check as Company case
+                    continue
+                if len(partner.fiscalcode) != 16:
+                    # Check fiscalcode of a person
+                    return False
+        return True
 
     fiscalcode = fields.Char(
         'Fiscal Code', size=16, help="Italian Fiscal Code")

diff --git a/l10n_it_fiscalcode/tests/test_fiscalcode.py b/l10n_it_fiscalcode/tests/test_fiscalcode.py
@@ -1,6 +1,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
 from odoo.tests.common import TransactionCase
+from odoo.exceptions import ValidationError
 
 
 class TestFiscalCode(TransactionCase):
@@ -24,3 +25,29 @@ def test_fiscalcode_compute(self):
         # ---- Compute FiscalCode
         wizard.compute_fc()
         self.assertEqual(self.partner.fiscalcode, 'RSSMRA84H04H501X')
+
+    def test_fiscalcode_check(self):
+        # Wrong FC
+        with self.assertRaises(ValidationError):
+            self.env['res.partner'].create({
+                'name': 'Person',
+                'is_company': False,
+                'fiscalcode': '123',
+            })
+        # Correct FC
+        self.env['res.partner'].create({
+            'name': 'Person',
+            'is_company': False,
+            'fiscalcode': 'RSSMRA84H04H501X',
+        })
+        # Empty FC
+        self.env['res.partner'].create({
+            'name': 'Person',
+        })
+        # FC is VAT number
+        self.env['res.partner'].create({
+            'name': 'Person',
+            'company_name': 'Company',
+            'is_company': False,
+            'fiscalcode': '123456789',
+        })