Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restaurant page: Inhouse deployment instructions #28844

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Restaurant page: Inhouse deployment instructions #28844

merged 5 commits into from
Sep 23, 2024

Conversation

damon314159
Copy link
Member

Because

The current instructions are brittle, as outlined in the linked issue

This PR

  • Describes alternate deployment instructions which should provide less friction

Issue

Closes #28780

Additional Information

This is a little verbose. Open to suggestions on rewordings

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Sep 23, 2024
MaoShizhong
MaoShizhong reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

javascript/organizing_your_javascript_code/project_restaurant_page.md Outdated Show resolved Hide resolved
javascript/organizing_your_javascript_code/project_restaurant_page.md Outdated Show resolved Hide resolved
javascript/organizing_your_javascript_code/project_restaurant_page.md Outdated Show resolved Hide resolved
damon314159 and others added 3 commits September 23, 2024 20:45
@damon314159 @MaoShizhong
Break long paragraph in two
e94b3a8 
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
@damon314159 @MaoShizhong
Explain purpose of merge main
96a2a6a 
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
@damon314159
Add missing colon before list
9e27087
MaoShizhong
MaoShizhong approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Hopefully this will help avoid redeployment errors and the like.

@MaoShizhong MaoShizhong merged commit ac97b54 into TheOdinProject:main Sep 23, 2024
2 checks passed
@damon314159 damon314159 deleted the patch-1 branch September 23, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaoShizhong MaoShizhong MaoShizhong approved these changes

Assignees
No one assigned
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restaurant Page: Inhouse deployment instructions
2 participants
@damon314159 @MaoShizhong