Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculator: Improve expressions and sentences #29011

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

softy-dev
Copy link
Contributor

Because

Some nitpick changes to improve clarity, decrease redundancy, and make the instructions more readable.

This PR

  • Removes redundancy that doesn't add to meaning;
  • Makes some sentences more concise;
  • Improves consistency (for instance, instead of using both "Equals" and "=", only the latter is used).

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Oct 26, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these - nice improvements!

@MaoShizhong MaoShizhong merged commit c5e2ec1 into TheOdinProject:main Oct 30, 2024
2 checks passed
@softy-dev softy-dev deleted the patch-3 branch October 30, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants