Skip to content

feat(repeatString): add instruction to use loops for implementation rather than builtin method #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

nik-rev
Copy link
Contributor

@nik-rev nik-rev commented May 3, 2024

There is a builtin method for accomplishing the same outcome, so I have updated the instructions as the point of the exercise is to practice loops.

@MaoShizhong
Copy link
Contributor

I'm hesitant on this one.

I believe the intention of the exercise is to get learners to get more practice with using loops. The hint quite firmly suggests this, but I feel for the exercise's intent, if loops are what it wants the learner to practise, it would be better placed in the actual exercise instructions instead of the hints section.

Basically saying that even though there is a built in string method for repeating strings, we want to practise loops so do it manually with loops instead. That way, they're also made aware of the string method.

@nik-rev nik-rev changed the title Exercise 2: Add solution that uses built-in method feat(repeatString): add instruction to use loops for implementation rather than builtin method Aug 9, 2024
@nik-rev
Copy link
Contributor Author

nik-rev commented Aug 9, 2024

I'm hesitant on this one.

I believe the intention of the exercise is to get learners to get more practice with using loops. The hint quite firmly suggests this, but I feel for the exercise's intent, if loops are what it wants the learner to practise, it would be better placed in the actual exercise instructions instead of the hints section.

Basically saying that even though there is a built in string method for repeating strings, we want to practise loops so do it manually with loops instead. That way, they're also made aware of the string method.

I've repurposed this PR

@nik-rev nik-rev requested a review from MaoShizhong August 10, 2024 16:25
@MaoShizhong MaoShizhong merged commit 29dd5a4 into TheOdinProject:main Aug 10, 2024
arod1104 added a commit to arod1104/odin-javascript-exercises that referenced this pull request Aug 11, 2024
…roject#460) (#1)

Intent is to practise using loops rather than wrap the built-in `repeat` String method.

Co-authored-by: Nikita Revenco <github.favoring288@simplelogin.fr>
major101x pushed a commit to major101x/javascript-exercises that referenced this pull request Aug 24, 2024
…roject#460)

Intent is to practise using loops rather than wrap the built-in `repeat` String method.
Oussama5379 added a commit to Oussama5379/javascript-exercises that referenced this pull request Feb 1, 2025
…roject#460)

Intent is to practise using loops rather than wrap the built-in `repeat` String method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants