05_sumAll: Update README.md #475
Conversation
There was a problem hiding this comment.
Thanks @shubhatRashid. In the future, could you please comment on the relevant issue and request to be assigned? Then only open a PR after you've been assigned by a maintainer as per our contributing guide.
Just need a quick spacing fix as well as removing the two unrelated changes that accidentally made their way into this commit.
| const removeFromArray = function(...arg) { | ||
There was a problem hiding this comment.
Reverting unrelated file to original state
| const removeFromArray = function(...arg) { | |
| const removeFromArray = function() { | |
| test('ignores non present values, but still works', () => { | ||
| expect(removeFromArray([1,2, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]); |
There was a problem hiding this comment.
Reverting unrelated file to original state
| test('ignores non present values, but still works', () => { | |
| expect(removeFromArray([1,2, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]); | |
| test.skip('ignores non present values, but still works', () => { | |
| expect(removeFromArray([1, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]); |
05_sumAll/README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Exercise 05 - sumAll | |||
|
|
|||
| Implement a function that takes 2 integers and returns the sum of every number between(and including) them: | |||
| Implement a function that takes 2 positive integers and returns the sum of every number between(and including) them: | |||
There was a problem hiding this comment.
Quick fix
| Implement a function that takes 2 positive integers and returns the sum of every number between(and including) them: | |
| Implement a function that takes 2 positive integers and returns the sum of every number between (and including) them: |
|
Hey @MaoShizhong , |
| @@ -1,5 +1,5 @@ | |||
| const removeFromArray = function() { | |||
|
|
|||
| @@ -14,7 +14,7 @@ describe('removeFromArray', () => { | |||
| expect(removeFromArray([1, 2, 3, 4], 7, "tacos")).toEqual([1, 2, 3, 4]); | |||
| }); | |||
| test.skip('ignores non present values, but still works', () => { | |||
| expect(removeFromArray([1, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]); | |||
| expect(removeFromArray([1,2, 3, 4], 7, 2)).toEqual([1, 3, 4]); | |||
There was a problem hiding this comment.
| expect(removeFromArray([1,2, 3, 4], 7, 2)).toEqual([1, 3, 4]); | |
| expect(removeFromArray([1, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]); |
|
Hey @MaoShizhong , |
|
My pleasure... |
* Change 'integers' to 'positive integers' in question statement * requested changes * requested changes * requested changes
Because
The test cases for the sumAll question suggested that the integers needed to be positive however no such thing was mentioned in question statement .
This PR
Changes the question statement which previously stated to 'form a function for integers' to 'form a function for positive integers'
Issue
Closes #255
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection/solutionsfolder