-
Notifications
You must be signed in to change notification settings - Fork 40.6k
05_sumAll: Update README.md #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
05_sumAll: Update README.md #475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shubhatRashid. In the future, could you please comment on the relevant issue and request to be assigned? Then only open a PR after you've been assigned by a maintainer as per our contributing guide.
Just need a quick spacing fix as well as removing the two unrelated changes that accidentally made their way into this commit.
const removeFromArray = function(...arg) { | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting unrelated file to original state
const removeFromArray = function(...arg) { | |
const removeFromArray = function() { | |
test('ignores non present values, but still works', () => { | ||
expect(removeFromArray([1,2, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting unrelated file to original state
test('ignores non present values, but still works', () => { | |
expect(removeFromArray([1,2, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]); | |
test.skip('ignores non present values, but still works', () => { | |
expect(removeFromArray([1, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]); |
05_sumAll/README.md
Outdated
@@ -1,6 +1,6 @@ | |||
# Exercise 05 - sumAll | |||
|
|||
Implement a function that takes 2 integers and returns the sum of every number between(and including) them: | |||
Implement a function that takes 2 positive integers and returns the sum of every number between(and including) them: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick fix
Implement a function that takes 2 positive integers and returns the sum of every number between(and including) them: | |
Implement a function that takes 2 positive integers and returns the sum of every number between (and including) them: |
Hey @MaoShizhong , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following bits are still necessary to remove the unrelated files from the PR
@@ -1,5 +1,5 @@ | |||
const removeFromArray = function() { | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -14,7 +14,7 @@ describe('removeFromArray', () => { | |||
expect(removeFromArray([1, 2, 3, 4], 7, "tacos")).toEqual([1, 2, 3, 4]); | |||
}); | |||
test.skip('ignores non present values, but still works', () => { | |||
expect(removeFromArray([1, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]); | |||
expect(removeFromArray([1,2, 3, 4], 7, 2)).toEqual([1, 3, 4]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect(removeFromArray([1,2, 3, 4], 7, 2)).toEqual([1, 3, 4]); | |
expect(removeFromArray([1, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]); |
Hey @MaoShizhong , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks!
My pleasure... |
* Change 'integers' to 'positive integers' in question statement * requested changes * requested changes * requested changes
Because
The test cases for the sumAll question suggested that the integers needed to be positive however no such thing was mentioned in question statement .
This PR
Changes the question statement which previously stated to 'form a function for integers' to 'form a function for positive integers'
Issue
Closes #255
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.01_helloWorld: Update test cases
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section/solutions
folder