Skip to content

06_leapYears/solution: Fix solution.js to align with README.md hint #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jveneziano25
Copy link
Contributor

… of this exercise.

Because

This PR changes the solution for Exercise 06 - leapYears, to align the solution with what has been taught up until this point of the course.

This PR

  • Changes solution.js to use if statements in combination with the && operator in order to match the hint in README.md and to better align with the concepts taught up to this point in the course.

Issue

Closes #482

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01_helloWorld: Update test cases
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR includes any changes that affect the solution of an exercise, I've also updated the solution in the /solutions folder

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MaoShizhong MaoShizhong merged commit 3c636be into TheOdinProject:main Jun 27, 2024
@jveneziano25 jveneziano25 deleted the fix-exercise06-solution branch June 27, 2024 15:54
Oussama5379 added a commit to Oussama5379/javascript-exercises that referenced this pull request Feb 1, 2025
Replacement solution is closer to what most learners might think of due to the instructions' hints, and concepts they'll have been reasonably exposed to so far in the curriculum.
The original solution has been a curveball for quite a few people.

Co-authored-by: Josh Veneziano <jveneziano@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md hint doesn't match solution.js
2 participants