Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweak to version/product numbering #31

Closed
patrickhlauke opened this issue Mar 31, 2017 · 3 comments
Closed

Small tweak to version/product numbering #31

patrickhlauke opened this issue Mar 31, 2017 · 3 comments

Comments

@patrickhlauke
Copy link
Contributor

Following the recent change in version numbering (which is a great start), I was wondering if we could have a further tweak...

Currently, the 32bit and 64bit versions have subtly different file version numbers (2.0.1.85 and 2.0.1.69) and the same product version (2.0.1.0). I've changed the InnoSetup file to grab the latter for the installer (so the combined installer becomes aViewer2.0.1.0.exe). However, this can be a little confusing (see #29).

Is it possible to drop the last part of the product version, so it's just "2.0.1"? (or well, for the next release, "2.0.2")?

@patrickhlauke
Copy link
Contributor Author

aviewer

@patrickhlauke
Copy link
Contributor Author

To be clearer: the "file version" can certainly keep the last digits (the ".85" and ".69" etc) if that's something that's bumped up automatically every time it's compiled. This would just be about the "product version" being the same between those two - and, as discussed before, being reasonably strict about using http://semver.org/ with MAJOR.MINOR.PATCH numbering for that part

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards-compatible manner, and
PATCH version when you make backwards-compatible bug fixes.

@patrickhlauke patrickhlauke assigned ghost Mar 31, 2017
ghost pushed a commit that referenced this issue May 2, 2017
@ghost
Copy link

ghost commented May 2, 2017

I stopped automatic increment, and dropped it.
ssav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant