Disable mypy "method-assign" errors in tests module #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add mypy override for our tests module, that disables the "method-assign" error, and remove existing comments that are disabling this check.
Motivation and Context
In our tests, we often overwrite methods on classes with MagicMock to mock out some behaviour. Mypy doesn't like this and throws a "method-assign" error. Until now, we've been adding
# type: ignore[method-assign]comments to disable this where we need to use mocks.This PR instead removes those existing comments, and disables this check for the tests package. It is still enabled for our normal code, where we should not be mocking like this.
This is the recommended work-around from the mypy issue here: python/mypy#2427
How Has This Been Tested?
Checklist