Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Python 3.12 in CI #691

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Test Python 3.12 in CI #691

merged 1 commit into from
Oct 30, 2024

Conversation

jonathangreen
Copy link
Member

Description

  • Run tests against Python 3.12.
  • Drop support for Python 3.8, 3.9 since we don't support them anywhere else
  • Update the pyupgrade hook for py310. A couple automated type hint changes came in via this change.

Motivation and Context

Make sure we are compatible for upgrade when the time comes 🚀

Similar to: ThePalaceProject/circulation#2146

How Has This Been Tested?

  • Running tests in CI

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team October 30, 2024 20:11
tdilauro
tdilauro approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍄

@jonathangreen jonathangreen merged commit ac4d0bc into main Oct 30, 2024
8 checks passed
@jonathangreen jonathangreen deleted the chore/python3.12 branch October 30, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdilauro tdilauro tdilauro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathangreen @tdilauro