Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge v2 to v3 #75

Merged
merged 2 commits into from
Feb 11, 2025
Merged

merge v2 to v3 #75

merged 2 commits into from
Feb 11, 2025

Conversation

Triplkrypl
Copy link
Member

No description provided.

@Triplkrypl Triplkrypl self-assigned this Feb 7, 2025
@Triplkrypl Triplkrypl added the PHP SDK Thepay PHP SDK implemetation label Feb 7, 2025
joseftraxler
joseftraxler requested changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@joseftraxler joseftraxler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't be version 2.1.1 in SDK v3.x

@Triplkrypl
Copy link
Member Author

It can't be version 2.1.1 in SDK v3.x

Now we have version 2.0.0

api-client/src/TheClient.php

Line 41 in 8347219

public const VERSION = '2.0.0';
in v3.x branche, I can make fix in v3.x branche, after we merge this to avoid merge conflic.

@Triplkrypl Triplkrypl merged commit deaefc6 into v3.x Feb 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseftraxler joseftraxler joseftraxler approved these changes

Assignees

@Triplkrypl Triplkrypl

Labels
PHP SDK Thepay PHP SDK implemetation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Triplkrypl @joseftraxler