Add PHP version constraint #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because you're using `[]` in the code, we need at least version 5.5.* of PHP to be installed on the system.
|
Oh, quick note: This might have to be part of the next major version (5.x) because some people's deployment process might break because of this. |
|
I'm all for upgrading the minimum PHP version, but the short array syntax was added in PHP 5.4, not PHP 5.5. Apart from that I'd recommend upgrading to PHP 7 from next major version. Thanks! |
|
@hkdobrev you're right, it was actually introduced in 5.4. My bad! @ThePixelDeveloper, can you amend this in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're using
[]in the code, we need at least PHP 5.5.* to be installed on the system.