Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bashrc to bash_aliases source for installation #71

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

Sh3llch0k
Copy link
Contributor

Corrected the source command after adding exegol alias in .bash_aliases (.bashrc doesn't include .bash_aliases by default on some distros like Arch Linux).

Corrected the source command after adding exegol alias in .bash_aliases (.bashrc doesn't include .bash_aliases on some distros like Arch Linux).
Copy link
Member

@Dramelac Dramelac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using .bash_aliases is intended in order to follow best practice.
If your .bashrc doesn't include .bash_aliases if the file exist you should add this config instead.

Moreover, changing the source file to .bash_aliases in the doc will not fix any issue because it'll only work for your one current session but will not be auto-loaded next time.

@Sh3llch0k
Copy link
Contributor Author

Using .bash_aliases is intended in order to follow best practice. If your .bashrc doesn't include .bash_aliases if the file exist you should add this config instead.

Moreover, changing the source file to .bash_aliases in the doc will not fix any issue because it'll only work for your one current session but will not be auto-loaded next time.

Noted, I will add a tip section instead of modifying the source command then.

Adding a tip for specific distros like Arch Linux instead of changing the source command during installation process.
@Sh3llch0k Sh3llch0k requested a review from Dramelac November 24, 2024 09:54
@ShutdownRepo
Copy link
Member

lgtm, @Dramelac agreed ?

@ShutdownRepo ShutdownRepo merged commit 5cf88c8 into ThePorgs:main Dec 16, 2024
1 check passed
@Sh3llch0k Sh3llch0k deleted the patch-1 branch December 16, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants