Add tools description #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Will take a look asap |
|
Cancelled checks because the target branch was wrong. Fixed branch, can you fix the conflicts? |
ShutdownRepo
requested changes
Mar 28, 2023
| @@ -1238,15 +1349,15 @@ function install_bloodhound_old_v3() { | |||
| unzip /tmp/BloodHound-linux-x64.zip -d /opt/tools/ | |||
| mv /opt/tools/BloodHound-linux-x64 /opt/tools/BloodHound3 | |||
| rm /tmp/BloodHound-linux-x64.zip | |||
| } | |||
| }# | |||
There was a problem hiding this comment.
}# : this indicates this tool is duplicated and his version should not be documented because it would cause a duplication
There was a problem hiding this comment.
alright, we should probably add a comment indicating that then
|
Thank you for the help but there are still a lot of broken/wrong links ... I'm putting this PR on hold. Let us know when it is fully ready for review and validation. |
|
I'm working on it |
added 3 commits
April 4, 2023 13:03
|
Good ? |
|
Conflict solved |
|
Before we go into review mode, did you check all links and descriptions to make sure they match? |
|
yep |
ShutdownRepo
removed
the
waiting for additional changes
This was referenced Apr 15, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello there ! What about some tools description ?
Related issues
Roadmap : https://github.com/orgs/ThePorgs/projects/1/views/1?pane=issue&itemId=21406532
Point of attention
I hope there is no mistake !