Fix remote dumping errors

ThePorgs · Jan 13, 2025 · fdc6598 · fdc6598
1 parent 6ee9e9b
commit fdc6598
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/examples/secretsdump.py b/examples/secretsdump.py
@@ -294,6 +294,7 @@ def dump(self):
                         try:
                             if self.__isRemote is True:
                                 SAMFileName = self.__remoteOps.saveSAM()
+                                samFormat = "save"
                             elif self.__samHive:
                                 SAMFileName = self.__samHive
                                 samFormat = "save"
@@ -312,6 +313,7 @@ def dump(self):
                         try:
                             if self.__isRemote is True:
                                 SECURITYFileName = self.__remoteOps.saveSECURITY()
+                                securityFormat = "save"
                             elif self.__securityHive:
                                 SECURITYFileName = self.__securityHive
                                 securityFormat = "save"

diff --git a/impacket/winregistry.py b/impacket/winregistry.py
@@ -718,8 +718,8 @@ def __init__(self, hive, isRemote = False, hiveFormat = 'save'):
             self.__registryParser = exportRegistryParser(hive)
 
     def close(self):
-        if hasattr(self, 'fd'):
-            self.fd.close()
+        if hasattr(self.__registryParser, 'fd'):
+            self.__registryParser.fd.close()
 
     def __del__(self):
         self.close()