Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating PartialConfigItem definitions #468

Merged

Conversation

wllfaria
Copy link

@wllfaria wllfaria commented Jan 1, 2024

Inserting the select_with_nil field and providing a detailed explanation on what it does.
Updating add -> create_list_item to proper reflect what the code is doing. it was changed here

This should close #450

I'm thinking about documenting the extensions section. As of this day I've built 2 small little extensions myself, so I read a lot of the code for extensions, what do you think?

Copy link

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@ThePrimeagen ThePrimeagen merged commit 4e5672c into ThePrimeagen:harpoon2 Jan 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants