Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ptrfication reviews round... 4(?) #44

Merged
merged 5 commits into from
Apr 19, 2022
Merged

ptrfication reviews round... 4(?) #44

merged 5 commits into from
Apr 19, 2022

Conversation

BoxyUwU
Copy link

@BoxyUwU BoxyUwU commented Apr 18, 2022 •
edited
Loading

  • Write proper docs for Ptr types
  • Undo some changes to world/mod.rs that are pointless
  • Undo some changes to world/entity_ref.rs that are pointless
  • Undo some changes to system/query.rs that are pointless

@BoxyUwU @alice-i-cecile
docs
b06cbf9 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@BoxyUwU BoxyUwU force-pushed the ptrification_ptr_reviews branch from 0b6c4cd to b06cbf9 Compare April 18, 2022 22:47
@BoxyUwU BoxyUwU changed the title Docs for ptr module Docs for ptr module and undo needless changes Apr 18, 2022
@BoxyUwU BoxyUwU changed the title Docs for ptr module and undo needless changes ptrfication reviews round... 4(?) Apr 18, 2022
@TheRawMeatball TheRawMeatball merged commit b76d47a into TheRawMeatball:smallish-ptrification Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BoxyUwU @alice-i-cecile @TheRawMeatball