Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Capitalize in Pascal #2249

Merged
merged 2 commits into from
Oct 18, 2020
Merged

Conversation

smjalageri
Copy link
Contributor

@smjalageri smjalageri commented Oct 17, 2020

Accept a String from command-line, convert first character of String to upper case
Pascal Strings begins with 1, not 0

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding a New Code Snippet in an Existing Language

  • I fixed Add Capitalize in Pascal #2248
  • I named the pull request using Add Capitalize FIrst Letter of String in Pascal format
  • I created/updated the language README (see contributing documentation)
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

I Am Adding a New Code Snippet in a New Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust
  • I created/updated the language README (see contributing documentation)
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

I Am Adding New Tests for a Project

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} tests format
  • I verified the project exists on the Sample Programs Project List
  • I added tests for every test case in the Testing table of the project description for the given project. (See contributing documentation)

I Am Adding New Tests for a Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {LANGUAGE} tests format\
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust
  • I verified all tests are passing

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed #your-issue-number-here
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

Other Notes

Add notes here...

Accept a String from command-line, convert first character of String to upper case
   Pascal Strings begins with 1, not 0
@smjalageri smjalageri changed the title convert first character of String to upper case Capitalize in Pascal Oct 17, 2020
@jrg94 jrg94 changed the title Capitalize in Pascal Added Capitalize in Pascal Oct 17, 2020
jrg94
jrg94 previously requested changes Oct 17, 2020
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it pass all cases! The only thing is the formatting is a bit odd. I don't know anything about pascal, but there are definitely some oddities with the spacing. I included a couple examples below.

archive/p/pascal/capitalize.pas Outdated Show resolved Hide resolved
archive/p/pascal/capitalize.pas Outdated Show resolved Hide resolved
archive/p/pascal/capitalize.pas Outdated Show resolved Hide resolved
@jrg94 jrg94 self-assigned this Oct 17, 2020
@jrg94 jrg94 added capitalize See: https://sampleprograms.io/projects/capitalize/ enhancement Any code that improves the repo labels Oct 17, 2020
@jrg94 jrg94 added this to the 1,000 Code Snippets milestone Oct 17, 2020
Awesome Jeremy, 
You take time to check this, ..

This is helping me write better code.

Thank you
@auroq auroq dismissed jrg94’s stale review October 18, 2020 16:39

Spacing appears to be resolved, now.

@auroq auroq merged commit 92e1021 into TheRenegadeCoder:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
capitalize See: https://sampleprograms.io/projects/capitalize/ enhancement Any code that improves the repo
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Capitalize in Pascal
3 participants