Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Hello World in Astro #2296

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Added Hello World in Astro #2296

merged 2 commits into from
Oct 27, 2020

Conversation

asharma13524
Copy link
Contributor

I Am Adding a New Code Snippet in an Existing Language

I fixed #1075

github-actions[bot]
github-actions bot reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @asharma13524! Thanks for contributing to this project! We are a rather small team, so it may take some time to process this request. In the meantime, there are several ways you can make yourself a part of The Renegade Coder community. For instance, you can:

Thanks for your help!

@jrg94 jrg94 changed the title added hello world in astro Added Hello World in Astro Oct 23, 2020
jrg94
jrg94 requested changes Oct 26, 2020
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We've recently changed our requirements, so we can't add this program as-is. Do you know if a Docker image exists for this language?

@jrg94 jrg94 self-assigned this Oct 26, 2020
@jrg94 jrg94 added enhancement Any code that improves the repo hello world See: https://sampleprograms.io/projects/hello-world/ needs tests New language or project that isn't tested labels Oct 26, 2020
@jrg94 jrg94 added this to the 1,000 Code Snippets milestone Oct 26, 2020
@asharma13524
Copy link
Contributor Author

I'm not quite sure. I'm also new to the language. I do not believe so after googling and checking out their repository. I could be wrong though.

jrg94
jrg94 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a peek! You're right. The language is in its alpha, and it hasn't been updated in awhile. I suspect there is no Docker image. We'll go ahead and add it in because I like having an archive of these sorts of languages.

@jrg94 jrg94 merged commit 46b8868 into TheRenegadeCoder:master Oct 27, 2020
@jrg94
Copy link
Member

jrg94 commented Oct 27, 2020

Whoops! We're missing the README. Any chance you'd want to put one of those together?

@jrg94 jrg94 mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
enhancement Any code that improves the repo hello world See: https://sampleprograms.io/projects/hello-world/ needs tests New language or project that isn't tested
Projects
Code Snippets
Archived in project
Milestone
1,000 Code Snippets
Development

Successfully merging this pull request may close these issues.

Add Hello World in Astro
2 participants
@asharma13524 @jrg94