Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Reverse String in FORTRAN #2324

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Conversation

msj2
Copy link
Contributor

@msj2 msj2 commented Oct 25, 2020

Add Reverse String in Fortran

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding a New Code Snippet in an Existing Language

  • I fixed Add Reverse String in Fortran #2322
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format
  • I created/updated the language README (see contributing documentation)
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

I Am Adding a New Code Snippet in a New Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust
  • I created/updated the language README (see contributing documentation)
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

I Am Adding New Tests for a Project

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} tests format
  • I verified the project exists on the Sample Programs Project List
  • I added tests for every test case in the Testing table of the project description for the given project. (See contributing documentation)

I Am Adding New Tests for a Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {LANGUAGE} tests format\
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust
  • I verified all tests are passing

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed #your-issue-number-here
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

Other Notes

Add notes here...

Add Reverse String in Fortran
@msj2
Copy link
Contributor Author

msj2 commented Oct 26, 2020

In the build-job, I searched for reverse-string.f90
I couldn't find it..

How to check, if the tests for Fortran are running?

@jrg94
Copy link
Member

jrg94 commented Oct 27, 2020

We're currently using FORTRAN 95 for testing. I have no idea if your code is compatible, but I updated the extension to kick off testing.

@jrg94 jrg94 requested a review from a team October 27, 2020 03:29
@jrg94 jrg94 self-assigned this Oct 27, 2020
@jrg94 jrg94 added enhancement Any code that improves the repo reverse string See: https://sampleprograms.io/projects/reverse-string/ labels Oct 27, 2020
@jrg94 jrg94 added this to the 1,000 Code Snippets milestone Oct 27, 2020
@jrg94 jrg94 changed the title Add Reverse String in FORTRAN Added Reverse String in FORTRAN Oct 27, 2020
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes! 👍

@jrg94 jrg94 merged commit 66c3526 into TheRenegadeCoder:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo reverse string See: https://sampleprograms.io/projects/reverse-string/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Reverse String in Fortran
2 participants