-
-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Objective-C Tests #3648
Merged
Merged
Add Objective-C Tests #3648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzuckerm
added
enhancement
Any code that improves the repo
tests
Testing related
labels
Dec 14, 2023
jrg94
approved these changes
Dec 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine this was a nightmare. I think I tried to do this one a few times in the past, but the language is so ugly I had to stop. 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.
Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation
I Am Adding New Tests for a Language
Add {LANGUAGE} Tests
formattestinfo.yml
files (see contributing documentation)Other Notes
I had to change every sample program in Objective-C to get the tests to pass. I tried to keep the existing logic as close as possible. One of the main changes is going from
NSLog
toprintf
in order to remove the timestamps theNSLog
does. I had to add input parsing and validation. I use ChatGPT to help out with that since I've never programmed in Objective-C. Finally, I had to change@autoreleasepool
toNSAutoreleasePool
anddrain
to fix compiler errors since@autoreleasepool
is only available withclang
, and I usedgcc
.It might be easier to review this ignoring whitespace changes.