Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Demo General Infantry Play Terrorist Sound Effect When Killed #101

Merged
merged 4 commits into from
Aug 29, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Aug 28, 2021

ZH 1.04:

  • Demo General's Infantry units play the blown up Terrorist sound effect when killed with an explosive, despite not doing any additional damage. This is confusing to players, because that sound effect also indicates usage of the Suicide/Demolitions ability.

After this patch:

  • Blowing up the unit with explosives uses the same death effect as blowing up any other unit, while using the Suicide ability plays the Terrorist sound effect. Therefore: Sound effect heard => damage dealt.

@commy2 commy2 added the Bug Something is not working right label Aug 28, 2021
@xezon xezon self-requested a review August 29, 2021 12:23
@commy2 commy2 merged commit ad31180 into main Aug 29, 2021
@commy2 commy2 deleted the fix-demo-suicide-effects-infantry branch August 29, 2021 12:57
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker GLA Affects GLA faction labels Mar 18, 2023
@commy2 commy2 mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants