Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Fire Visuals For Aflame Units #1103

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add: Fire Visuals For Aflame Units #1103

wants to merge 5 commits into from

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Sep 4, 2022

  • USA vehicles
  • China vehicles
  • GLA vehicles
  • Civilian and misc vehicles
  • buildings? Buildings already handle AFLAME status via FireS/M/L hard-coded bones.

@xezon xezon added the Experimental Wear safety goggles in lab label Sep 4, 2022
@xezon

This comment was marked as outdated.

@xezon

This comment was marked as outdated.

@commy2
Copy link
Collaborator

commy2 commented Nov 6, 2022

Fire effects last too long

The effect is removed immediately when the vehicle stops losing health.

@xezon
Copy link
Collaborator Author

xezon commented Nov 6, 2022

Ah okay, when it is linked to actual damage duration, then that duration makes sense. Is quite long.

@xezon xezon added the Minor Severity: Minor < Major < Critical < Blocker label Aug 8, 2023
@commy2 commy2 force-pushed the burn branch 2 times, most recently from b3dd5ad to 94626be Compare August 11, 2023 22:01
@commy2 commy2 added Enhancement Is new feature or request USA Affects USA faction China Affects China faction GLA Affects GLA faction Civilian Affects Civilian faction Boss Affects Boss faction and removed Experimental Wear safety goggles in lab labels Aug 12, 2023
@commy2
Copy link
Collaborator

commy2 commented Aug 12, 2023

Done for the base factions.

We need a map with all the civ vehicles (Crush test has no player controllable flamer).

Buildings already burn when damaged and AFLAME: engine creates larger fires and less smoke at FireS/M/Lxx memory points while burning.

Base defenses lack these, so I recommend to at least add the flame to Tunnel/Stinger/Patiot/Fire Base/Bunker/Gattling/Prop Tower and Demo Trap.

@xezon
Copy link
Collaborator Author

xezon commented Aug 12, 2023

Would it perhaps be possible to put the flames at custom positions on the chassis so that the fire does not spawn from below the vehicle? The flame underneath vehicles does not look optimal in my opinion.

shot_20230812_183708_3

@commy2 commy2 force-pushed the burn branch 2 times, most recently from 36bd822 to 7b10932 Compare August 23, 2023 22:26
@commy2
Copy link
Collaborator

commy2 commented Aug 23, 2023

z-Positions of the fire now editable in INI. Should look better now. Can be fine tuned for each unit.

End
ConditionState = AFLAME
Model = FireSource
ParticleSysBone = Source05 AflameVehicleMedium
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SourceXX where XX is z position in feet. Range [00-20] where 00 is the floor.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Perhaps call the bones X00Y00Z00-X00Y00Z20 or Center00-Center20? This would communicate their position more clearly.

We need to check that carrying these extra 20 bones per each object is ok.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bones only exist when AFLAME. No model otherwise.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to CenterZxx. It's supposed to mean the center x,y at z=...

@xezon
Copy link
Collaborator Author

xezon commented Aug 24, 2023

The fires are too intense for my liking. I have made a pass on them.

I have used InfernoCannonFire and DragonTransitionFire as references.

Before

shot_20230824_165825_3

After

shot_20230824_181444_1

@xezon
Copy link
Collaborator Author

xezon commented Aug 24, 2023

Flamed aircraft appears to produce no fire

shot_20230824_170011_4

@commy2
Copy link
Collaborator

commy2 commented Aug 24, 2023

I haven't added it to aircraft or civilian cars yet. It may also need to be added to base defenses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Boss Affects Boss faction China Affects China faction Civilian Affects Civilian faction Enhancement Is new feature or request GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants