Fix: Keep disabled Helix attachment upgrade buttons in Command Set #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Bug
xezon
force-pushed
the
fix-helix-commandset
branch
from
b9fe090 to
b3de98d
Compare
xezon
changed the title
Stubbjax
approved these changes
Jan 12, 2023
|
I kept the legacy command sets in case some mod map uses them. |
Surely this patch already contains or will end up containing changes that result in similar incompatibilities? Are we limited to changes that won't affect some abandoned mod map from a decade ago? Cleaner / more manageable ini files feels more beneficial to me. |
|
Even if we have some changes that make mod map already incompatible, we can still curb removals, because then there are less things mod maps need to change to adapt to patch. |
|
What legacy command sets? I thought we agreed to revert the bomb buttons |
|
Helix Command Set count was reduced from 4 to 1. |
|
Count of What? I don't see any difference, can you explain? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies Helix attachment Command Set. Buttons will no longer disappear after research. This means shortcut key can be used on multi Helix selection to build an upgrade any time.
This behavior is consistent with USA vehicle drone upgrade buttons.