-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: USA Battle Plan tool tip text details #1559
Conversation
It's a better description, but "All ground units" is technically wrong too. It doesn't increase the firepower of Drones like the Sentry Drone. It also doesn't increase the damage caused by Demogen Workers suicide ability, while it works on all other GLA unit's suicide ability. |
Do we consider drones as ground units? They are floating above ground, so it seems they are excluded from "ground". The Demogen Worker damage is a bug? |
Sentry Drones. Just rewrite it to "Vehicles and Infantry". Drones are not vehicles and Workers are not Infantry. |
Oversight I would say. He's a DOZER kind, but DOZER is on the forbidden list for Strat Center bonuses. Just removing DOZER from the forbidden list would make Hold The Line give extra HP to the USA Dozer though. Just ignore that as a quirk. |
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The collocation "Infantry and Vehicles" feels unnatural. In English, the semantically larger "vehicles" would typically come first, e.g. "Vehicles and Infantry", and the lighter word often comes first as well.
9a3740b
to
10d7945
Compare
Fixed. Also added change comments to str file. I made a mistake in gametextcompiler tool and comments start with |
What are the implications of this? Can't you just commit a fix? |
I would need to hook up new gametextcompiler version to Mod Builder first. |
But it is fine to be in the main branch and won't cause issues? |
This change as is right now does work with the backslashes. |
10d7945
to
ee626a5
Compare
Comments now use forward slashes. Everything works. |
This change fixes wrong and inaccurate information in USA Battle Plan tool tip texts.
TODO