Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add CRATE flag to SalvageCrate #1675

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Fix: Add CRATE flag to SalvageCrate #1675

merged 1 commit into from
Apr 11, 2023

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Feb 11, 2023

This change adds the CRATE flag to SalvageCrate object. All other Crates have this flag too. Appears to make no difference in player facing behavior.

@xezon xezon added the Minor Severity: Minor < Major < Critical < Blocker label Feb 11, 2023
@Stubbjax
Copy link
Collaborator

It would be good to know what the CRATE flag does so we don't end up with unforeseen consequences.

@xezon
Copy link
Collaborator Author

xezon commented Feb 12, 2023

Thyme does not yet have any CRATE logic laid out, so we cannot see exactly what CRATE does, if anything. However, we know that the other Crate objects have this flag, and we know that SalvageCrate has KindOf setup issues, such as SELECTABLE flag, so to me it looks like this flag is just missing. When there is a CRATE KindOf, then a Crate Object more likely than not should have it. I was unable to observe difference in behaviour of SalvageCrate with and without this flag however.

@xezon xezon force-pushed the fix-salvage-1-crate-flag branch from 20b811c to adc05b4 Compare February 22, 2023 17:11
@xezon
Copy link
Collaborator Author

xezon commented Apr 11, 2023

;gs I added parachutable as a catch all to prevent making new kindofs (like CRATE)

Looks like CRATE was originally created to make the object PARACHUTABLE.

@xezon xezon added the GLA Affects GLA faction label Apr 11, 2023
@xezon xezon force-pushed the fix-salvage-1-crate-flag branch from adc05b4 to fe4ca19 Compare April 11, 2023 15:43
@xezon
Copy link
Collaborator Author

xezon commented Apr 11, 2023

Documentation added. Looks good.

@xezon xezon merged commit 20b90e5 into main Apr 11, 2023
@xezon xezon deleted the fix-salvage-1-crate-flag branch April 11, 2023 15:44
@xezon xezon added the Design Is a matter of game design label Apr 11, 2023
@ItsWazzaP ItsWazzaP added the GameMismatchWith104 Affects game state towards original 1.04 label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Is a matter of game design GameMismatchWith104 Affects game state towards original 1.04 GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants