Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Removes the destruction delay variance from the USA Alpha Aurora's bomb #1752

Merged
merged 2 commits into from
Apr 9, 2023

Conversation

Stubbjax
Copy link
Collaborator

This change removes the 100ms destruction delay variance from the Aurora Alpha's bomb weapon. It's not ideal that important gameplay elements (particularly arbitrary ones like this one) are randomised in such a way, and it's best to minimise them where possible.

After this change, the Aurora Alpha bomb's fuel-air explosion will always detonate exactly 1000ms (30 frames) after igniting, instead of a random time between 1000ms (30 frames) and 1100ms (33 frames).

Although this is technically a buff, it should be noted that this partially cancels out the increased detonation delay of 3 to 5 frames introduced by #292. (In 1.04, the fuel ignites 2 to 4 frames before impact, whereas the fuel ignites one frame after impact as of #292.)

@Stubbjax Stubbjax added Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker Buff Makes a thing more powerful USA Affects USA faction labels Feb 24, 2023
@xezon xezon changed the title Change: Removed the destruction delay variance from the Aurora Alpha's bomb weapon Change: Removes the destruction delay variance from the USA Alpha Aurora's bomb Apr 9, 2023
@xezon xezon force-pushed the fix-aurora-alpha-bomb-explosion-delay branch from d8dc298 to 6a249c0 Compare April 9, 2023 13:53
Copy link
Collaborator

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@xezon xezon force-pushed the fix-aurora-alpha-bomb-explosion-delay branch from 6a249c0 to 55ae9b6 Compare April 9, 2023 13:55
@xezon xezon merged commit 1732c85 into main Apr 9, 2023
@xezon xezon deleted the fix-aurora-alpha-bomb-explosion-delay branch April 9, 2023 13:56
@xezon xezon added the Controversial Is controversial label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Buff Makes a thing more powerful Controversial Is controversial Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants