Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Decrease small poison field radius from 12 to 7.5 #2014

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Jun 17, 2023

This change decreases small poison field radius from 12 to 7.5 to match small Anthrax Beta and Anthrax Gamma fields radius. The small poison field is used by Scorpion Tank toxin shells.

The particle effect size was adjusted to closer match the damage radius.

Weapon Original Damage Radius Patched Damage Radius
SmallPoisonFieldWeapon 12 7.5
SmallPoisonFieldWeaponUpgraded 7.5
Chem_SmallPoisonFieldWeaponGamma 7.5
GC_Chem_GLARebelGunGamma 10
Chem_ToxinTruckGunGamma 10
SmallRadiationFieldWeapon 15
Nuke_SmallRadiationFieldWeapon 12

Rationale

The damage radius of Toxin Shells no longer becomes worse after acquiring the Anthrax Beta upgrade.

@xezon xezon added Bug Something is not working right Controversial Is controversial Minor Severity: Minor < Major < Critical < Blocker Nerf Makes a thing less powerful GLA Affects GLA faction labels Jun 17, 2023
@xezon
Copy link
Collaborator Author

xezon commented Jun 17, 2023

7.5 is certainly a small radius. The INI code comment suggests that the developers raised the poison field radius from initial 7.5 to 12 but forgot to adjust Anthrax Beta and Anthrax Gamma along with it. Perhaps the plan was to match the nuke radiation radius of the Battle Master.

Personally I think 9 or 10 would also be a good radius. But 7.5 looks safe for starters to fix the bug, as it will only affect GLA and Demo General after Toxin Shells upgrade without Anthrax Beta upgrade.

@MTKing4
Copy link
Collaborator

MTKing4 commented Jun 17, 2023

Pretty sure demo doesn't have any anthrax upgrades

@xezon
Copy link
Collaborator Author

xezon commented Jun 18, 2023

Ok. Only affects GLA General after Toxin Shells upgrade and without Anthrax Beta upgrade.

@ImTimK
Copy link
Collaborator

ImTimK commented Jun 18, 2023

Change is fine.

@xezon xezon changed the title Fix: Decrease small poison field radius to match small Anthrax Beta and Anthrax Gamma Fix: Decrease small poison field radius from 12 to 7.5 Jun 18, 2023
@xezon xezon force-pushed the tweak-poison-radius branch from ed232af to a695a9d Compare June 18, 2023 11:54
@xezon
Copy link
Collaborator Author

xezon commented Jun 18, 2023

Documentation added. Looks good. This is how close infantry can stand to Toxin Shell.

shot_20230618_135801_15

@xezon xezon merged commit a66c4ba into main Jun 18, 2023
@xezon xezon deleted the tweak-poison-radius branch June 18, 2023 12:04
@commy2
Copy link
Collaborator

commy2 commented Jun 20, 2023

Pretty sure demo doesn't have any anthrax upgrades

While Demo doesn't get Toxin Shells or Anthrax Beta/Gamma, Toxin Shells is still compatible with Demo Scorpions and Marauders. E.g. if you manage to build a Tox General Command Center as Demo, or build a vGLA Palace and purchase the Toxin Shells upgrade, your Demo Scorpions will fire poison shells and create puddles.

Anthrax Beta and Anthrax Gamma will also upgrade the damage over time of the puddle. So Toxin Shells Anthrax Gamma Demo Scorpions are a thing.

@MTKing4
Copy link
Collaborator

MTKing4 commented Jun 20, 2023

Woah

Holy shit

@xezon xezon added the Design Is a matter of game design label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right Controversial Is controversial Design Is a matter of game design GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker Nerf Makes a thing less powerful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anthrax Beta Decreases Radius of Effect of Small Poison Clouds
4 participants