-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add English Localization File #281
Conversation
What do you want to add that for? And does it load from inside .big file? |
So text edits can be made, which some of my tasks require.
Pretty sure it does. |
How is this generals.str file generated? I am asking because typically we use generals.csf file for text edits. Also, we cannot just apply fixes to the English localization. Changes need to be applied to all language files. I can provide all .csf files except for Brazilian. |
Exported it with FinalBig. Then used the CSFtoSTR(0.9.3).exe tool. Iirc I also had to clean up a few special characters. (Quote marks?)
Would be awesome if you can taker over this and give contributors a way to make text edits. |
Tools here #306 |
Depends on how many tasks remain that do not involve text changes. I guess in two weeks would be nice, so no hurry.
As far as I can tell, there is literally no reason to use CSF. |
There are a few considerations:
|
Can CSF do that? |
Load order will pick the first copy of CSF it finds. In regards to STR, we would need to test and understand how it interacts with CSF file. I can do some tests and figure out what to do with it. |
|
Ok this on its own already voids STR approach. |
I was told this same problem applies to CSF files, because some people change their hotkeys in the CSF file inside the EnglishZH.big file. At least that was the reason given that no text changes at all are possible in the 1.04+ patch. Is there a STR -> CSF compiler? |
We could write a STR to CSF command line tool and embed this within our build scripts, so that we can edit text files but it will be compiled into CSF automatically on build. This would be more comfortable for development. CSF file edited in EnglishZH.big is very uncommon I would say. The most common and likely scenario will be a extracted GENERALS.CSF, because that will take precedence over all other CSF files. |
I opened a task here and will take care of implementing it all. |
This is the English 1.04 text. .STR file is easily editable and accepted by the game.
However we implement this, and changes in this file, it has to be optional, so we don't fuck up people's custom hotkeys.