Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Tomahawk And Non Demo General Scud Launcher Scrap Creation Module Tags #390

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 19, 2021

Module tags can't contain spaces. SalvageData is just a free floating string and the actal module names becomes just ModuleTag.

ModuleTags are used for ReplaceModule and RemoveModule in map.ini files.

Strangely this does not affect the Demo Generals Scud Launcher, which uses ModuleTag_Salvage with and underscore. This is why I went with that name.

@commy2 commy2 merged commit bb58f47 into main Sep 20, 2021
@commy2 commy2 deleted the fix-bad-module-name branch September 20, 2021 07:36
xezon pushed a commit that referenced this pull request Aug 28, 2022
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Bug Something is not working right labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants