Change: USA War Factory door time from 3250 to 3300 ms #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Design
xezon
force-pushed
the
door-fix-america-wf
branch
from
9d66a79 to
2250b0a
Compare
xezon
added a commit
that referenced
this pull request
Aug 28, 2022
xezon
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
This change fixes the slow door close time of USA War Factory.
With an update clock of 66.666 ms we can calculate that actual door time will be 3250 Modulus 66.66666 = 50, leading in 3250 + 50 = 3300 ms. Setting Open door time to 3300 makes it explicit and easier to comprehend. Closing door change is inconsequential to gameplay, as it does not affect any unit interactions.
This change is cosmetic.
Original
usa_wf_original.mp4
Patched
usa_wf_patch.mp4