Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Error fix for creation of application [refer: Error creating application #63] #64

Merged
merged 3 commits into from
Mar 20, 2019

Conversation

naveen-25
Copy link
Contributor

Application creation throws the NOT FOUND error. The URL is malformed with reference to https://www.thethingsnetwork.org/docs/network/account/api.html. Fixed the issue by modifying the url.

Application creation throws the NOT FOUND error. The URL is malformed with reference to https://www.thethingsnetwork.org/docs/network/account/api.html. Fixed the issue by modifying the url.
@CLAassistant
Copy link

CLAassistant commented Mar 7, 2019

CLA assistant check
All committers have signed the CLA.

@johanstokking
Copy link
Contributor

Thanks @naveen-25

Is there a way we can fix CI?

@naveen-25
Copy link
Contributor Author

naveen-25 commented Mar 8, 2019

Thanks @naveen-25

Is there a way we can fix CI?

Fixed the CI issue. The issue is because of the https://github.com/TheThingsNetwork/ttn.git is in out of sync with the JAVA SDK.

@@ -69,7 +69,6 @@ private AsyncDiscovery(DiscoveryGrpc.DiscoveryFutureStub _stub) {
try {
ManagedChannel ch = ManagedChannelBuilder
.forAddress(_host, _port)
.usePlaintext(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid we need this for private networks still

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the current SDK fails because of trying to connect with the secured server. Is there any workaround?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it an option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally added the secure connection.

@@ -2,7 +2,7 @@
root=$(pwd)
workdir="$root/src/main/proto"
javaPackageName='org.thethingsnetwork.management.proto'
branch='master'
branch='feature/pprof'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should we do in order for this to stay master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to remove the dependency with the ttn code base. Shall I proceed with that and commit the changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the dependencies with the TTN code

Copy link
Contributor

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johanstokking johanstokking merged commit 2b94a3c into TheThingsArchive:master Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants