-
Notifications
You must be signed in to change notification settings - Fork 25
Error fix for creation of application [refer: Error creating application #63] #64
Conversation
Application creation throws the NOT FOUND error. The URL is malformed with reference to https://www.thethingsnetwork.org/docs/network/account/api.html. Fixed the issue by modifying the url.
Thanks @naveen-25 Is there a way we can fix CI? |
Fixed the CI issue. The issue is because of the https://github.com/TheThingsNetwork/ttn.git is in out of sync with the JAVA SDK. |
@@ -69,7 +69,6 @@ private AsyncDiscovery(DiscoveryGrpc.DiscoveryFutureStub _stub) { | |||
try { | |||
ManagedChannel ch = ManagedChannelBuilder | |||
.forAddress(_host, _port) | |||
.usePlaintext(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid we need this for private networks still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the current SDK fails because of trying to connect with the secured server. Is there any workaround?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it an option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optionally added the secure connection.
management/run.sh
Outdated
@@ -2,7 +2,7 @@ | |||
root=$(pwd) | |||
workdir="$root/src/main/proto" | |||
javaPackageName='org.thethingsnetwork.management.proto' | |||
branch='master' | |||
branch='feature/pprof' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should we do in order for this to stay master
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to remove the dependency with the ttn code base. Shall I proceed with that and commit the changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the dependencies with the TTN code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Application creation throws the NOT FOUND error. The URL is malformed with reference to https://www.thethingsnetwork.org/docs/network/account/api.html. Fixed the issue by modifying the url.