Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate file for adding-oauth-clients documentation #1377

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

nicholaspcr
Copy link
Contributor

@nicholaspcr nicholaspcr commented Sep 16, 2024

Summary

Closes #1136

Adds a separate page for adding an OAuth client. This basically introduces the TTSS considerations provided in the issue alongside an already existent documentation in https://www.thethingsindustries.com/docs/api/concepts/auth/oauth-access-tokens/

Screenshots

localhost_1313_the-things-stack_interact_adding-oauth-clients_

localhost_1313_api_concepts_auth_oauth-access-tokens_

Changes

  • Create page on integrations/adding-oauth-clients/
  • Update content of api/concepts/auth/oauth-access-tokens/

Notes for Reviewers

This includes the image change where the Enabled checkbox in the grant section now displays the proper label value.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

@nicholaspcr nicholaspcr added this to the Sep 2024 milestone Sep 16, 2024
@nicholaspcr nicholaspcr self-assigned this Sep 16, 2024
@nicholaspcr nicholaspcr marked this pull request as ready for review September 18, 2024 11:00
Copy link
Contributor

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not belong in integrations. That section is meant for users to get LoRaWAN traffic out of TTS or into TTS (downlinks)
I think we can put this in https://www.thethingsindustries.com/docs/the-things-stack/interact/

@KrishnaIyer KrishnaIyer modified the milestones: Sep 2024, Oct 2024 Oct 6, 2024
@nicholaspcr nicholaspcr merged commit 98253bb into master Oct 11, 2024
1 check passed
@nicholaspcr nicholaspcr deleted the doc/oauth-clients branch October 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for building OAuth clients
3 participants