Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List effective routing policies of non-listed networks #4388

Closed
johanstokking opened this issue Jul 10, 2021 · 4 comments · Fixed by #4489
Closed

List effective routing policies of non-listed networks #4388

johanstokking opened this issue Jul 10, 2021 · 4 comments · Fixed by #4489
Assignees
Labels
c/packet broker agent This is related to Packet Broker Agent in progress We're working on it size/small This should not be a lot of work
Milestone

Comments

@johanstokking
Copy link
Member

Summary

List effective routing policies of non-listed networks

Why do we need this?

To see all routing policies that apply

What is already there? What do you see now?

Currently, the Console fetches first all the (listed) networks, for instance:

https://tti.eu1.cloud.thethings.industries/api/v3/pba/networks?page=1&limit=20&name_contains=&tenant_id_contains=&with_routing_policy=false

Then, the Console fetches all the effective routing policies:

https://tti.eu1.cloud.thethings.industries/api/v3/pba/forwarders/policies?page=1&limit=1000

The Console then matches the policies of the second response with the networks returned by the first response. This is good and by initial design.

However, there are more effective routing policies in the second response that are not being shown, because those networks are not listed and are therefore not included in the first response.

What is missing? What do you want to see?

I would like to see all effective forwarder routing policies.

How do you propose to implement this?

I think we should do the following three tabs:

  1. All policies. This tab should show the result of passing with_routing_policy=true to the /api/v3/pba/networks call. This will show all networks with an effective routing policy
  2. Non-default policies. This is the same as what is already there
  3. All listed home networks. This should show the contents of the current All tab

How do you propose to test this?

I can configure a few things on staging if that is helpful

Can you do this yourself and submit a Pull Request?

Can test

@johanstokking johanstokking added c/console This is related to the Console ui/web This is related to a web interface labels Jul 10, 2021
@johanstokking johanstokking added this to the v3.14.1 milestone Jul 10, 2021
@github-actions github-actions bot added the needs/triage We still need to triage this label Jul 10, 2021
@johanstokking johanstokking removed the needs/triage We still need to triage this label Jul 10, 2021
@kschiffer
Copy link
Contributor

For such unlisted networks, it would not be possible to list the network name (if exists) and dev address blocks, since it is not part of the policy responses. Is there a way we can still get those, or can we include them in the policy responses? Or alternatively, couldn't the network response list unlisted networks as well, in case they have a policy set up towards the own network? I feel like otherwise we're patchworking things a bit.

@kschiffer kschiffer added the needs/discussion We need to discuss this label Jul 30, 2021
@kschiffer kschiffer modified the milestones: v3.14.1, v3.14.2 Aug 2, 2021
@johanstokking
Copy link
Member Author

Or alternatively, couldn't the network response list unlisted networks as well, in case they have a policy set up towards the own network?

I'll look into this and get back.

@johanstokking johanstokking added c/packet broker agent This is related to Packet Broker Agent and removed needs/discussion We need to discuss this c/console This is related to the Console ui/web This is related to a web interface labels Aug 4, 2021
@johanstokking johanstokking modified the milestones: v3.14.2, v3.14.1 Aug 4, 2021
@johanstokking
Copy link
Member Author

@kschiffer's proposal is sound; I'll cram this in for 3.14.1.

@johanstokking johanstokking added the in progress We're working on it label Aug 4, 2021
@johanstokking johanstokking added the size/small This should not be a lot of work label Aug 4, 2021
@johanstokking
Copy link
Member Author

Closed by #4489

ryaplots added a commit that referenced this issue Sep 3, 2024
…-crash

Filter bookmarks by main entities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/packet broker agent This is related to Packet Broker Agent in progress We're working on it size/small This should not be a lot of work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants