-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List effective routing policies of non-listed networks #4388
Comments
For such unlisted networks, it would not be possible to list the network name (if exists) and dev address blocks, since it is not part of the policy responses. Is there a way we can still get those, or can we include them in the policy responses? Or alternatively, couldn't the network response list unlisted networks as well, in case they have a policy set up towards the own network? I feel like otherwise we're patchworking things a bit. |
I'll look into this and get back. |
@kschiffer's proposal is sound; I'll cram this in for 3.14.1. |
Closed by #4489 |
…-crash Filter bookmarks by main entities
Summary
List effective routing policies of non-listed networks
Why do we need this?
To see all routing policies that apply
What is already there? What do you see now?
Currently, the Console fetches first all the (listed) networks, for instance:
https://tti.eu1.cloud.thethings.industries/api/v3/pba/networks?page=1&limit=20&name_contains=&tenant_id_contains=&with_routing_policy=false
Then, the Console fetches all the effective routing policies:
https://tti.eu1.cloud.thethings.industries/api/v3/pba/forwarders/policies?page=1&limit=1000
The Console then matches the policies of the second response with the networks returned by the first response. This is good and by initial design.
However, there are more effective routing policies in the second response that are not being shown, because those networks are not listed and are therefore not included in the first response.
What is missing? What do you want to see?
I would like to see all effective forwarder routing policies.
How do you propose to implement this?
I think we should do the following three tabs:
with_routing_policy=true
to the/api/v3/pba/networks
call. This will show all networks with an effective routing policyHow do you propose to test this?
I can configure a few things on staging if that is helpful
Can you do this yourself and submit a Pull Request?
Can test
The text was updated successfully, but these errors were encountered: