Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gRPC metrics dependency #6343

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Update gRPC metrics dependency #6343

merged 1 commit into from
Jun 29, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

This PR replaces github.com/grpc-ecosystem/go-grpc-prometheus with github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus, as the former is deprecated and no longer receives updates.

Changes

  • Replace github.com/grpc-ecosystem/go-grpc-prometheus with github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus.

Testing

Local testing - there are no known metrics changes, but the original repository is no longer maintained.

Regressions

N/A.

Notes for Reviewers

We should upgrade github.com/grpc-ecosystem/go-grpc-middleware to their v2 once they have an official release. The migration guide is already available, and in general the only change that we need to take care of is the depreciation of grpc_ctxtags. The rest of the changes are not affecting us.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.27.0 milestone Jun 28, 2023
@adriansmares adriansmares self-assigned this Jun 28, 2023
@github-actions github-actions bot added dependencies Pull requests that update a dependency file tooling Development tooling labels Jun 28, 2023
@adriansmares adriansmares marked this pull request as ready for review June 28, 2023 17:35
@adriansmares adriansmares merged commit 0490cf9 into v3.26 Jun 29, 2023
16 checks passed
@adriansmares adriansmares deleted the deps/update-grpc-prom branch June 29, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file tooling Development tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants