Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Packet Broker audience from dial address #6346

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

johanstokking
Copy link
Member

@johanstokking johanstokking commented Jun 30, 2023

Summary

References https://github.com/TheThingsIndustries/lorawan-stack-support/issues/972

Changes

This fixes the issue that the token audience is not correctly parsed from the address to dial.

Testing

Unit test

Regressions

None expected

Notes for Reviewers

This is the least ugly version that I considered.

I didn't update the changelog yet because we need to decide if we backport this to 3.26.

Let's get this in for 3.26.2.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking johanstokking added this to the v3.27.0 milestone Jun 30, 2023
@johanstokking johanstokking self-assigned this Jun 30, 2023
@johanstokking johanstokking added size/small This should not be a lot of work c/packet broker agent This is related to Packet Broker Agent labels Jun 30, 2023
@johanstokking johanstokking changed the base branch from v3.27 to v3.26 June 30, 2023 19:17
@github-actions github-actions bot added c/application server This is related to the Application Server compat/api This could affect API compatibility dependencies Pull requests that update a dependency file and removed c/packet broker agent This is related to Packet Broker Agent labels Jun 30, 2023
@johanstokking johanstokking modified the milestones: v3.27.0, v3.26.2 Jun 30, 2023
@johanstokking johanstokking added c/packet broker agent This is related to Packet Broker Agent and removed c/application server This is related to the Application Server compat/api This could affect API compatibility dependencies Pull requests that update a dependency file labels Jun 30, 2023
@KrishnaIyer KrishnaIyer removed this from the v3.26.2 milestone Jul 3, 2023
@KrishnaIyer KrishnaIyer added this to the v3.27.0 milestone Jul 3, 2023
@adriansmares adriansmares changed the base branch from v3.26 to v3.27 July 3, 2023 08:49
@johanstokking johanstokking modified the milestones: v3.27.0, v3.26.2 Jul 3, 2023
@johanstokking johanstokking merged commit 79a095f into v3.27 Jul 3, 2023
14 of 16 checks passed
@johanstokking johanstokking deleted the fix/pba-aud-from-address branch July 3, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/packet broker agent This is related to Packet Broker Agent size/small This should not be a lot of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants