Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include body only if valid UTF8 #6375

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Include body only if valid UTF8 #6375

merged 1 commit into from
Jul 5, 2023

Conversation

adriansmares
Copy link
Contributor

@adriansmares adriansmares commented Jul 5, 2023 •
edited
Loading

Summary

Fixes https://the-things-industries.sentry.io/issues/4040291373

Changes

  • Include the request body into the debug events only if the body is valid UTF8. This applies to requests to other platforms like application layer webhooks or LoRaCloud integrations.

Testing

Local testing.

Regressions

N/A.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added the bug Something isn't working label Jul 5, 2023
@adriansmares adriansmares added this to the v3.27.0 milestone Jul 5, 2023
@adriansmares adriansmares self-assigned this Jul 5, 2023
@github-actions github-actions bot added the c/application server This is related to the Application Server label Jul 5, 2023
@adriansmares adriansmares marked this pull request as ready for review July 5, 2023 14:03
@adriansmares adriansmares merged commit c11ae4c into v3.27 Jul 5, 2023
@adriansmares adriansmares deleted the fix/as-panic branch July 5, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrishnaIyer KrishnaIyer KrishnaIyer approved these changes

@johanstokking johanstokking Awaiting requested review from johanstokking johanstokking is a code owner

Assignees

@adriansmares adriansmares

Labels
bug Something isn't working c/application server This is related to the Application Server
Projects
None yet
Milestone
v3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adriansmares @KrishnaIyer