Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable session reset callback #6380

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

adriansmares
Copy link
Contributor

Summary

References jackc/pgx#1673

Fixes the deadlock visible in https://github.com/TheThingsNetwork/lorawan-stack/actions/runs/5462658722/jobs/9942792699 .

Changes

  • Disable the session reset check while using the pgx driver until we have a clear solution to the background reader concurrency issues.

Testing

CI.

Regressions

pgx should already have other checks in place for connection closure detection, and as such this shouldn't cause any extra regressions.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added the bug Something isn't working label Jul 5, 2023
@adriansmares adriansmares added this to the v3.27.0 milestone Jul 5, 2023
@adriansmares adriansmares self-assigned this Jul 5, 2023
@adriansmares adriansmares marked this pull request as ready for review July 5, 2023 12:39
@adriansmares adriansmares merged commit b9d6ee0 into v3.27 Jul 5, 2023
@adriansmares adriansmares deleted the fix/disable-session-check branch July 5, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants