Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various fixes to the console redesign branch #7191

Merged
merged 11 commits into from
Jul 30, 2024

Conversation

ryaplots
Copy link
Contributor

Summary

This PR fixes several issues in the console redesign

Changes

  • Make a generic delete modal do use in the overview headers
  • Fix device info panel
  • Fix collapsed side footer
  • Move gateway header
  • Add delete end device and download mac settings buttons to device overview dropdown
  • Add links to entities in the organization view header

Testing

Steps

Log into the console and go over the described changes

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label Jul 22, 2024
@ryaplots ryaplots added this to the 2024 Q3 milestone Jul 22, 2024
@ryaplots ryaplots self-assigned this Jul 22, 2024
@ryaplots ryaplots requested a review from a team as a code owner July 22, 2024 09:13
@ryaplots ryaplots requested review from mjamescompton and kschiffer and removed request for a team July 22, 2024 09:13
Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

pkg/webui/lib/shared-messages.js Outdated Show resolved Hide resolved
@ryaplots ryaplots requested a review from kschiffer July 29, 2024 14:07
@ryaplots ryaplots merged commit db3815c into feature/console-redesign Jul 30, 2024
6 of 12 checks passed
@ryaplots ryaplots deleted the fix/mac-settings-download branch July 30, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants