Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font and weight values #7200

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

pierrephz
Copy link
Contributor

Summary

Clean up generic.styl file

Changes

  • merge fsv2 in fs
  • merge fwvs to fw

Testing

Steps

...

Results
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@pierrephz pierrephz self-assigned this Jul 29, 2024
@pierrephz pierrephz requested review from a team as code owners July 29, 2024 14:13
@pierrephz pierrephz requested review from johanstokking and removed request for a team July 29, 2024 14:13
@github-actions github-actions bot added the ui/web This is related to a web interface label Jul 29, 2024
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates git submodules (lorawan-devices and lorawan-frequency-plans) should not happen. Please revert that. Easiest is to update the submodules locally, check out the original version in their respective directories and then fixup the commit where they changed in this PR.

@johanstokking johanstokking dismissed their stale review July 30, 2024 09:24

This has been addressed

@johanstokking johanstokking removed their request for review July 30, 2024 09:24
@kschiffer kschiffer merged commit df85c76 into feature/console-redesign Aug 1, 2024
6 of 12 checks passed
@kschiffer kschiffer deleted the fix/font-size branch August 1, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants