Fix interference of entity prefetching data with store state #7207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This quickfix fixes an issue with the entity fetching store logic in the Console redesign branch, related to how entities are prefetched for the top entities logic.
Changes
Testing
Steps
Notes for Reviewers
Some more background:
Previously I was using the regular
GET_XXX_LIST
-actions, which connect to the pagination reducer (pkg/webui/lib/store/reducers/pagination.js
). This means that they store the list of IDs that are connected to the paginated requests, so that the Console can select them from the global list of entities and show them in the current list view. Currently the list actions run concurrently and whichever resolves last will win (I've also removedlatest
option for this reason), which can sometimes be the prefetch for the top entities. If we just fetch the entities to have them in the store, we don't want to mess with the pagination store, as they are not meant to be displayed the current list view. Hence, creating a new set ofFETCH_XXX_LIST
-actions which do the same as the regularGET_XXX_LIST
except storing the IDs in the pagination store will resolve this issue.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.