Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor datasheet to use flexbox and add responsive #7221

Merged
merged 8 commits into from
Aug 13, 2024

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Aug 6, 2024

Summary

This PR refactors the dataSheet component to use flex box to be more flexible to responsiveness

Changes

  • Use flex box
  • Add responsive behavior

Testing

Steps

...

Results
Screenshot 2024-08-05 at 17 00 53

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label Aug 6, 2024
@ryaplots ryaplots added this to the 2024 Q3 milestone Aug 6, 2024
@ryaplots ryaplots self-assigned this Aug 6, 2024
@ryaplots ryaplots requested a review from a team as a code owner August 6, 2024 09:17
@ryaplots ryaplots requested review from PavelJankoski, kschiffer and a team and removed request for a team August 6, 2024 09:17
Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also include the changes that convert the sections into accordions:
image

It should be possible to solve this with CSS and media queries only. You'd have to track which groups are open/closed in the component state to apply the respective class to each group, then only use these classes in mobile views to show/hide the respective groups.

Please also take care to apply accurate spacing and alignment as per the screendesign.

In the current implementation, there are alignment issues:
image

@ryaplots ryaplots requested a review from kschiffer August 8, 2024 17:07
@kschiffer
Copy link
Contributor

Looking good already but the spacing is still a bit wonky:
image

The red area is too much spacing, and I've added my idea of how the spacing should work for individual items.

@ryaplots
Copy link
Contributor Author

ryaplots commented Aug 9, 2024

I've removed the excess margin and edited the spacings, however, I didn't make exactly like you are suggesting because then the grey divider does not have the correct width, so I have to bound it by the panel paddings. I tried to make spacing less honky and more predictable:
Screenshot 2024-08-09 at 17 13 08
Screenshot 2024-08-09 at 17 13 15

@ryaplots ryaplots merged commit 7e59902 into feature/console-redesign Aug 13, 2024
8 of 12 checks passed
@ryaplots ryaplots deleted the fix/data-sheet-component branch August 13, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants