Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new event types to application server #7269

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

vlasebian
Copy link
Contributor

@vlasebian vlasebian commented Aug 27, 2024

Summary

References #4227 (tti issue).

Changes

Add events that can be associated with event types propagated by webhooks.

Testing

Steps
  1. Have a local instance of the stack up and running with an app and a device
  2. Simulate uplinks for each type of message that triggers a specific event, e.g.
APP=$1
DEV=$2

curl -i "http://localhost:1885/api/v3/as/applications/$APP/devices/$DEV/up/simulate" \
  -H "Authorization: $TTS_AUTH_TOKEN" \
  -d '{
  "downlink_ack": {
    "session_key_id": "string",
    "f_port": 0,
    "f_cnt": 0,
    "frm_payload": "string",
    "decoded_payload": {},
    "decoded_payload_warnings": [
      "string"
    ],
    "confirmed": true,
    "class_b_c": {
      "gateways": [
        {
          "gateway_ids": {
            "gateway_id": "string",
            "eui": "70B3D57ED000ABCD"
          },
          "antenna_index": 0,
          "group_index": 0
        }
      ],
      "absolute_time": "2024-08-27T08:50:56.236Z"
    },
    "priority": "LOWEST",
    "correlation_ids": [
      "string"
    ],
    "confirmed_retry": {
      "attempt": 1,
      "max_attempts": 100
    }
  }
}'
  1. Check the live data tab in the console
Results
Screenshot 2024-08-27 at 15 55 35
Regressions

None.

Notes for Reviewers

None.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@github-actions github-actions bot added the c/application server This is related to the Application Server label Aug 27, 2024
@vlasebian vlasebian changed the title as: Add new event types Add new event types to application server Aug 27, 2024
@vlasebian vlasebian force-pushed the feature/downlink-events-in-as branch from c631daa to 1b2e03a Compare August 27, 2024 14:00
@vlasebian vlasebian marked this pull request as ready for review August 27, 2024 14:00
@vlasebian vlasebian requested a review from a team as a code owner August 27, 2024 14:00
@vlasebian vlasebian self-assigned this Aug 27, 2024
@vlasebian vlasebian added this to the v3.32.1 milestone Aug 27, 2024
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

pkg/applicationserver/observability.go Outdated Show resolved Hide resolved
@vlasebian vlasebian force-pushed the feature/downlink-events-in-as branch from 28c6c8f to e5e8b62 Compare August 29, 2024 10:28
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@KrishnaIyer
Copy link
Member

Please run tools/bin/mage go:messages to resolve the diff.

@github-actions github-actions bot added the ui/web This is related to a web interface label Sep 2, 2024
@vlasebian vlasebian merged commit a9e1dbc into v3.32 Sep 2, 2024
14 of 15 checks passed
@vlasebian vlasebian deleted the feature/downlink-events-in-as branch September 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/application server This is related to the Application Server ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants