-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint for claiming gateways using a qr code #7272
Conversation
8ec181c
to
0571b93
Compare
What should be filled in for the rest of the ClaimGatewayRequest? The full request looks like this: {
"authenticated_identifiers": {
"gateway_eui": "70B3D57ED000ABCD", // this is taken from the url
"authentication_code": "string" // this is taken from the url too
},
"qr_code": "string", // if authenticated_identifiers are provided, this doesn't have to be filled in
// how should the collaborator item be filled?
"collaborator": {
"organization_ids": {
"organization_id": "string"
},
"user_ids": {
"user_id": "string",
"email": "string"
}
},
// there is a comment for target_gateway_id in the protobuf message definition:
// 'If this is not set, the target ID for the target gateway will be set
// to `<gateway-eui>`.' -> I guess this can be set to the gatewayEUI
"target_gateway_id": "string",
"target_gateway_server_address": "string", // what value should we use for this? we let the user select it?
// cups_redirection is deprecated
"cups_redirection": {},
// target_frequency_plan_id is deprecated
"target_frequency_plan_id": "string",
// what should we use for this?
"target_frequency_plan_ids": [
"string"
]
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Please address lint errors and set up the linting tool in your editor.
1371c77
to
84deef9
Compare
84deef9
to
a546ae6
Compare
ad6dbcb
to
281d218
Compare
e04c4ad
to
f5be211
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f5be211
to
d780ef2
Compare
Summary
References #7270
Changes
Testing
where the qr_code field is the base64 encoded value of:
or without specifying the format:
Results
Regressions
None.
Notes for Reviewers
None.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.