Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toast component in e2e tests #7293

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Sep 10, 2024

Summary

Fix toasts testing in e2e tests.

Changes

  • Add a data-test-id per toast type
  • Test per toast type

Testing

Steps

Run e2e tests with a license warning toast always showing.

Results
Regressions

Tests should pass anyway

Notes for Reviewers

In one of the previous CI runs, all the e2e tests were failing due to a warning toast being rendered. This toast was showing because the ci license key was about to expire, which is the correct behavior. However, the e2e tests should not fail in this case, they should be resilient to the UI having more than one toast.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots self-assigned this Sep 10, 2024
@ryaplots ryaplots added the ui/web This is related to a web interface label Sep 10, 2024
@ryaplots ryaplots modified the milestones: v3.32.1, 2024 Q3 Sep 10, 2024
@ryaplots ryaplots marked this pull request as ready for review September 10, 2024 10:37
@ryaplots ryaplots requested a review from a team as a code owner September 10, 2024 10:37
@ryaplots ryaplots merged commit e9460fd into v3.32 Sep 13, 2024
13 checks passed
@ryaplots ryaplots deleted the fix/e2e-tests-notifications branch September 13, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants