Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid consecutive disconnect/reconnect messages in the Live Data view #7383

Open
wants to merge 2 commits into
base: v3.33
Choose a base branch
from

Conversation

ryaplots
Copy link
Contributor

Summary

References #4685

Changes

  • Add condition to not add any other disconnect event messages if there are already consecutive disconnect messages in the events and remove the reconnect event message if another disconnect happens immediately after, this way keeping the first disconnect and the latest reconnect.

Testing

Steps
  1. Go to live data view
  2. Either leave the browser tab unfocused for a long while or (easier) disconnect from Wi-Fi or internet a couple of times
  3. See no consecutive disconnects/reconnects events.
Results
Screenshot 2024-11-15 at 10 14 27

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added c/console This is related to the Console ui/web This is related to a web interface labels Nov 15, 2024
@ryaplots ryaplots added this to the v3.33.0 milestone Nov 15, 2024
@ryaplots ryaplots self-assigned this Nov 15, 2024
@ryaplots ryaplots requested a review from a team as a code owner November 15, 2024 09:14
@ryaplots ryaplots force-pushed the fix/consecutive-disconnect-messages branch from e5f9eb7 to dc5c134 Compare November 15, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant