Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdcycle rdtime rdinstret pseudo-instructions's bug #62

Closed
mvlamar opened this issue Nov 20, 2019 · 1 comment
Closed

rdcycle rdtime rdinstret pseudo-instructions's bug #62

mvlamar opened this issue Nov 20, 2019 · 1 comment

Comments

@mvlamar
Copy link

mvlamar commented Nov 20, 2019

Hi,
I think the PseudoOps.txt has a bug in the instructions below, where rd register should be replaced by RG1 register, according to:

rdcycle t1 ; csrrs RG1, 0xC00, x0 ;# Read from cycle
rdtime t1 ; csrrs RG1, 0xC01, x0 ;# Read from time
rdinstret t1 ; csrrs RG1, 0xC02, x0 ;# Read from instret
rdcycleh t1 ; csrrs RG1, 0xC80, x0 ;# Read from cycleh
rdtimeh t1 ; csrrs RG1, 0xC81, x0 ;# Read from timeh
rdinstreth t1 ; csrrs RG1, 0xC82, x0 ;# Read from instreth

[]
Marcus Vinicius
TheThirdOne added a commit that referenced this issue Nov 21, 2019
@TheThirdOne
Fix rdCSR psuedo-instructions
4c0bff7 
The instructions used rd instead of RG1 which would
make it fail to assemble correctly.

I should add some testing apparatus to make sure that
a bug like this doesn't appear again. It has appeared before.

Fixes #62
@TheThirdOne
Copy link
Owner

TheThirdOne commented Nov 21, 2019 •
edited
Loading

This should be fixed now.

I don't know exactly how to do it, but I would like to make an automated test to warn me if any pseudo-instruction doesn't use a register argument.

Thanks again for another good bug report.

TheThirdOne added a commit that referenced this issue Nov 23, 2019
@TheThirdOne
Add test that checks psuedo ops expand correctly
fc73f49 
Currently it is very basic, it only checks that the given example
assembles and if registers are changed, the binary result changes.

This test revealed a bugs in some psuedo-instructions which are also fixed.

I mentioned making this change in #62
marcelachim pushed a commit to marcelachim/rars that referenced this issue Dec 20, 2024
@ElTitoDG
Add jpackage plugin for creating app distribution binaries (TheThirdO…
1225b63 
…ne#62)

* tested jpackage plugin
* added color icon version + mac dmg
* icons for other platforms
* added win config and linux
* config changed to build package based on Host OS

close TheThirdOne#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheThirdOne @mvlamar