Improved indentation system #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheThirdOne Hello again! Have you had any time to review this? |
TheThirdOne
reviewed
Feb 16, 2023
| // manager use them for focus traversal. | ||
| // One can also accomplish this using: setFocusTraversalKeysEnabled(false); | ||
| // but that seems heavy-handed. | ||
| // DPS 12May2010 | ||
| KeyboardFocusManager.getCurrentKeyboardFocusManager().addKeyEventDispatcher( | ||
| new KeyEventDispatcher() { | ||
| public boolean dispatchKeyEvent(KeyEvent e) { | ||
| if (JEditTextArea.this.isFocusOwner() && e.getKeyCode() == KeyEvent.VK_TAB && e.getModifiers() == 0) { | ||
| int modifiers = e.getModifiers(); | ||
| if (JEditTextArea.this.isFocusOwner() && e.getKeyCode() == KeyEvent.VK_TAB |
There was a problem hiding this comment.
This seems to be overcomplicating the matter a bit, but if simplified to JEditTextArea.this.isFocusOwner() && e.getKeyCode() == KeyEvent.VK_TAB CTRL + TAB results in a stack overflow for some reason.
|
I'm sorry it took me a while to get to this. I meant to get to this over both of the past weekends. Looks good. It acts like most other text editors. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to:
TABSHIFT + TAB