Community seeds #72
Community seeds #72
Conversation
…o copy/paste config strings to send to other people
|
I can't really give a thorough review right now but I didn't see anything too out of the ordinary so feel free to continue |
|
@Vivelin I added in the ability to specify any progression item as an early item, but I ran into issues where sometimes specifying them will randomly run into infinite loops when generating seeds (though not always). It handles it somewhat gracefully and warns the user, but want to see if I can figure out why it's happening and think about how to best address it. |
- Fixed issue with silver arrows causing problems due to them being referred to as progression in some areas but not others - Added location/item settings and the config string to spoiler log - Added seed logging to the debug logs for easier debugging - Fixed various corner case issues with setting item/locations - Added test cases
- Handling some errors better in case of seeds that can't be beaten come up - Fixing some more corner cases where it would try to put a progression item behind a place that needs that item
|
@Vivelin After pulling my hair out for hours, I think I've got this pretty stable. There were a mountain of corner cases that were arising when I was trying to run stats or unit tests that revolving around how it shuffled items around. Obviously still certain combinations people put in may be unbeatable, but it should catch those situations upon generation and warn people. I'm going to do some more testing tomorrow, but otherwise this should be good to go. |
|
I'll give it a review in a minute. It might be best to release this soon-ish (mark it as pre-release for now?) so there's a little more time to test. I've had some other small changes I wanted to make but we've already got more than enough to warrant a new release, I think. |
| @@ -271,6 +190,11 @@ | |||
| <TextBox x:Name="SeedInput" | |||
| Text="{Binding Seed}" /> | |||
| </controls:LabeledControl> | |||
|
|
|||
| <controls:LabeledControl Text="Config string (optional):"> | |||
There was a problem hiding this comment.
"Config string" might not be the best name for this in the UI... Maybe import/export buttons? Or "Copy settings" and "Import from clipboard" or something like that?
| var selectedRegion = comboBox.SelectedItem as string; | ||
| foreach (FrameworkElement obj in LocationsGrid.Children) { | ||
| var location = obj.Tag as Location; | ||
| obj.Visibility = selectedRegion.Contains(location.Region.Name) ? Visibility.Visible : Visibility.Collapsed; |
There was a problem hiding this comment.
This can cause a null reference exception if Tag is ever not a location or null.
- Fixed not null checking tag - Updated terminology for config strings in UI - Added logic options to spoiler log
|
Fixed all of the above and added the logic config to the spoiler log. If you aren't able to make a build today, I probably can tonight my time. |
|
Yeah, I won't have time today. |
Adding the ability to have more granular control over what gets generated where and adding the ability to share configs, opening the possibility for community created seeds for streamers to play.