Clear dungeon fix #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…locations might need to be double-checked
MattEqualsCoder
previously approved these changes
Mar 21, 2022
| Say(x => x.DungeonAlreadyCleared, dungeon.Name); | ||
| } | ||
|
|
||
| OnDungeonUpdated(new(confidence)); |
There was a problem hiding this comment.
Minor, but is there a reason to do this and the below if it doesn't actually do anything?
There was a problem hiding this comment.
No, I was lazy but you're right, I should fix this.
MattEqualsCoder
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked clear dungeon to always clear all locations and remaining treasure. Tracker will also mention if any locations might need to be double-checked because they were out of logic (but still clears them).
Resolves #89