Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Android project no longer builds if useExoplayerHls = false #3948

Closed
EETVApps opened this issue Jun 27, 2024 · 1 comment · Fixed by #3950
Closed

[BUG]: Android project no longer builds if useExoplayerHls = false #3948

EETVApps opened this issue Jun 27, 2024 · 1 comment · Fixed by #3950
Labels

Comments

@EETVApps
Copy link
Contributor

Version

6.3.0

What platforms are you having the problem on?

Android

System Version

Any

On what device are you experiencing the issue?

Real device

Architecture

Old architecture

What happened?

The fix for #3766 means that any app that doesn't choose to include the Media3 HLS libraries will now fail to build. This is due to the new requirement for setAllowChunklessPreparation to exist on HlsMediaSource.Factory.

A stub implementation exists in the project to allow code to compile without including the HLS libraries - I believe it just needs to be updated to add the stub method.

Reproduction

repository link

Reproduction

Try to build the app with useExoplayerHls = false

@EETVApps EETVApps added the bug label Jun 27, 2024
@EETVApps EETVApps changed the title No longer builds if useExoplayerHls = false [BUG]: Android project no longer builds if useExoplayerHls = false Jun 28, 2024
darrentaft pushed a commit to EETVApps/react-native-video-conviva that referenced this issue Jun 28, 2024
…ctory to allow build success on projects without HLS support (TheWidlarzGroup#3948)
darrentaft pushed a commit to EETVApps/react-native-video-conviva that referenced this issue Jun 28, 2024
…ctory to allow build success on projects without HLS support (TheWidlarzGroup#3948)
KrzysztofMoch pushed a commit that referenced this issue Jun 28, 2024
…ctory to allow build success on projects without HLS support (#3948) (#3950)

Co-authored-by: Darren Taft <darren.taft@bt.com>
@KrzysztofMoch
Copy link
Member

Will be fixed in 6.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants